DAP-16 Input Share Validation algorithm updates #4304
Merged
+320
−89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Changes the processing of Extensions to not be a CodecError
- We don't want to abort the stream, we want to give report-level errors!
- Changes ExtensionType to have an Unknown type, which we then use as a sentinel
- Adds/updates tests to also exercise this
Fixes #4021
tgeoghegan
approved these changes
Jan 28, 2026
| let mut extensions = HashMap::new(); | ||
| if !plaintext_input_share.private_extensions().iter().chain(prepare_init.report_share().metadata().public_extensions()).all(|extension| { | ||
| extensions | ||
| for extension in plaintext_input_share.private_extensions().iter().chain(prepare_init.report_share().metadata().public_extensions()) |
Contributor
There was a problem hiding this comment.
I think rustfmt gives up on lines this long, but can we try to manually wrap it?
messages/src/lib.rs
Outdated
| pub enum ExtensionType { | ||
| Tbd = 0, | ||
| Taskbind = 0xFF00, | ||
| Tbd, |
Contributor
There was a problem hiding this comment.
Let's rename this to Reserved to match the specification.
Contributor
Author
There was a problem hiding this comment.
doh, I meant to do this. Thanks!
divergentdave
approved these changes
Jan 28, 2026
| debug!( | ||
| task_id = %task.id(), | ||
| report_id = ?prepare_init.report_share().metadata().id(), | ||
| unrecognized_etension_type = ?extension.extension_type(), |
Collaborator
There was a problem hiding this comment.
nit: typo
Suggested change
| unrecognized_etension_type = ?extension.extension_type(), | |
| unrecognized_extension_type = ?extension.extension_type(), |
| ); | ||
| metrics | ||
| .aggregate_step_failure_counter | ||
| .add(1, &[KeyValue::new("type", "unrecognized_extension")]); |
Collaborator
There was a problem hiding this comment.
We should add unrecognized_extension to the counter initialization loop, in aggregator/src/metrics.rs. This will keep Prometheus's rate() from missing the first nonzero sample.
Contributor
Author
There was a problem hiding this comment.
I looked around for this but I didn't look in the right places. Thanks! 49110e8
aggregator/src/aggregator.rs
Outdated
| debug!( | ||
| task_id = %task.id(), | ||
| report_id = ?report.metadata().id(), | ||
| unrecognized_etension_type = ?extension.extension_type(), |
Collaborator
There was a problem hiding this comment.
nit: typo
Suggested change
| unrecognized_etension_type = ?extension.extension_type(), | |
| unrecognized_extension_type = ?extension.extension_type(), |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4021