Don't allow creating a new project with the same name in the same place #215
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djdiskmachine
added a commit
that referenced
this pull request
Dec 30, 2025
Call ACTION_SAVE_AS NewProjectDialog with "root:" as path Change default currentPath to "root:" (fix regression caused in #215 Disallow accidental root folder access in FileSystem::Descend
djdiskmachine
added a commit
that referenced
this pull request
Dec 31, 2025
Save as now discards unsaved changes to current project Unsaved changes only written to project under new name Adds filesystem function Delete(Path&) Adds optional argument to PersistencyService::Save(const char* name) Save temp file Copy temp file to new location Delete temp file Bump CHANGELOG #212 * Guard against forbidden paths Call ACTION_SAVE_AS NewProjectDialog with "root:" as path Change default currentPath to "root:" (fix regression caused in #215) Disallow accidental root folder access in FileSystem::Descend #219
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow creating a project with the same name in a different path Pass currentDirectory to NewProjectDialog
Path field added to NewProjectDialog
When randomising a project name, re run randomizer if name already in use
Adresses #175
Type of change
Fixes Skip randomly generated project name if a directory with that name already exists #175
Bug fix (non-breaking change which fixes an issue)
How Has This Been Tested?
Please describe the tests procedure by which you verified your changes.
Provide instructions on how to reproduce.
Test Configuration:
Checklist:
sources/Application/Model/Project.h