Add delivery channels and thumbs ADR #613
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JackLewis-digirati
approved these changes
Sep 20, 2023
donaldgray
reviewed
Sep 20, 2023
Member
donaldgray
left a comment
donaldgray
left a comment
There was a problem hiding this comment.
These 2 are a bit different from the other ADR's, should they be updated to follow a similar format? IIRC these are based on the madr template
* Status: proposed
* Deciders: Tom Crane
* Date: 2023-09-20
# Context and Problem Statement
xxx
# Considered Options
yyy
# Decision Outcome
zzzNeed to update the update docs/adr/readme.md to update index.
Should they link to the RFC where delivery-channels were first mentioned? https://github.com/dlcs/protagonist/blob/main/docs/rfcs/009-asset-family-improvements.md
| Everything on a delivery channel is always served by the same application / service / component. Even if this means there is more than one delivery channel providing IIIF Image Services, or PDFs. It is not the format but the processing and transformation that determines the channel. An example of this is further developed in [ADR 0007](0007-delivery-channels-and-thumbs.md) | ||
|
|
||
|
|
||
| Future delivery channels could be things like: |
Member
There was a problem hiding this comment.
Capture decision that delivery-channel always matches first slug in URL?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order for a thumbs ADR there needed to be a delivery channels ADR.