-
-
Notifications
You must be signed in to change notification settings - Fork 27
New Crowdin updates #267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Crowdin updates #267
Conversation
Reviewer's GuideAdds new quest module localization keys for handling quests with unknown conditions across all supported languages, introducing labels and descriptions for a manual-quest handling mode. Sequence diagram for manual quest handling with unknown conditionssequenceDiagram
actor Player
participant ClientBot
participant GameServer
Player->>ClientBot: Enable_manual_quests
Player->>ClientBot: Start_quest_module
ClientBot->>GameServer: Select_quest_including_unknown_conditions
GameServer-->>ClientBot: Send_quest_details_and_conditions
ClientBot->>ClientBot: Evaluate_conditions
alt All_conditions_known
ClientBot->>GameServer: Execute_known_steps
GameServer-->>ClientBot: Update_quest_progress
ClientBot-->>Player: Quest_completed_automatically
else Unknown_condition_encountered
ClientBot-->>GameServer: Disconnect_on_unknown_condition
ClientBot-->>Player: Notify_manual_intervention_needed
Player->>GameServer: Complete_unknown_condition_manually
Player->>ClientBot: Reconnect_and_resume_other_quests
end
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey - I've found 1 issue, and left some high level feedback:
- The new
quest_module.manual_questsstrings are added identically in English across all locale files; if these are intended for translation rather than fallback, consider either adding localized text or leaving them only in the base language file until translations are available. - The description text
It even takes on quest it doesn't know how to do, and when it reaches a condition it doesn't know, it will disconnect so you can do it manually.is a bit awkward grammatically; consider rephrasing for clarity (e.g.,It will also accept quests it doesn't know how to complete, and when it encounters an unknown condition, it will disconnect so you can finish it manually).
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The new `quest_module.manual_quests` strings are added identically in English across all locale files; if these are intended for translation rather than fallback, consider either adding localized text or leaving them only in the base language file until translations are available.
- The description text `It even takes on quest it doesn't know how to do, and when it reaches a condition it doesn't know, it will disconnect so you can do it manually.` is a bit awkward grammatically; consider rephrasing for clarity (e.g., `It will also accept quests it doesn't know how to complete, and when it encounters an unknown condition, it will disconnect so you can finish it manually`).
## Individual Comments
### Comment 1
<location> `src/main/resources/com/deeme/lang/strings_es.properties:465` </location>
<code_context>
quest_module.quest_types_to_do=Type of quests to do
quest_module.quest_types_to_do.desc=Select the types of quests that the module should do
+quest_module.manual_quests=Unknown conditions
+quest_module.manual_quests.desc=It even takes on quest it doesn't know how to do, and when it reaches a condition it doesn't know, it will disconnect so you can do it manually.
urgent_detector=Urgent quests detector
</code_context>
<issue_to_address>
**nitpick (typo):** Minor grammar issue in the English description string.
The phrase "It even takes on quest it doesn't know how to do" is ungrammatical. Please change it to either "It even takes on quests it doesn't know how to do" or "It even takes on a quest it doesn't know how to do" for clarity.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| quest_module.quest_types_to_do=Tipo de misiones a hacer | ||
| quest_module.quest_types_to_do.desc=Seleccione los tipos de misiones que el módulo debe hacer | ||
| quest_module.manual_quests=Unknown conditions | ||
| quest_module.manual_quests.desc=It even takes on quest it doesn't know how to do, and when it reaches a condition it doesn't know, it will disconnect so you can do it manually. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nitpick (typo): Minor grammar issue in the English description string.
The phrase "It even takes on quest it doesn't know how to do" is ungrammatical. Please change it to either "It even takes on quests it doesn't know how to do" or "It even takes on a quest it doesn't know how to do" for clarity.
Summary by Sourcery
Add localization entries for handling quests with unknown conditions across all supported languages.
New Features: