Skip to content

Conversation

@dm94
Copy link
Owner

@dm94 dm94 commented Dec 26, 2025

Summary by Sourcery

Add localization entries for handling quests with unknown conditions across all supported languages.

New Features:

  • Introduce quest_module.manual_quests label for quests with unknown conditions in all language properties files.
  • Add quest_module.manual_quests.desc description explaining behavior when encountering unsupported quest conditions.

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Dec 26, 2025

Reviewer's Guide

Adds new quest module localization keys for handling quests with unknown conditions across all supported languages, introducing labels and descriptions for a manual-quest handling mode.

Sequence diagram for manual quest handling with unknown conditions

sequenceDiagram
    actor Player
    participant ClientBot
    participant GameServer

    Player->>ClientBot: Enable_manual_quests
    Player->>ClientBot: Start_quest_module

    ClientBot->>GameServer: Select_quest_including_unknown_conditions
    GameServer-->>ClientBot: Send_quest_details_and_conditions

    ClientBot->>ClientBot: Evaluate_conditions
    alt All_conditions_known
        ClientBot->>GameServer: Execute_known_steps
        GameServer-->>ClientBot: Update_quest_progress
        ClientBot-->>Player: Quest_completed_automatically
    else Unknown_condition_encountered
        ClientBot-->>GameServer: Disconnect_on_unknown_condition
        ClientBot-->>Player: Notify_manual_intervention_needed
        Player->>GameServer: Complete_unknown_condition_manually
        Player->>ClientBot: Reconnect_and_resume_other_quests
    end
Loading

File-Level Changes

Change Details Files
Introduce localization entries for a new "manual quests / unknown conditions" option in the quest module across all language property files.
  • Add quest_module.manual_quests key for the label of the new option in the quest module settings.
  • Add quest_module.manual_quests.desc key describing behavior when encountering unknown quest conditions (taking the quest, then disconnecting for manual completion).
  • Keep text content in English for now in all affected locale files, likely awaiting proper translations.
src/main/resources/com/deeme/lang/strings_bg.properties
src/main/resources/com/deeme/lang/strings_cs.properties
src/main/resources/com/deeme/lang/strings_de.properties
src/main/resources/com/deeme/lang/strings_el.properties
src/main/resources/com/deeme/lang/strings_es.properties
src/main/resources/com/deeme/lang/strings_fr.properties
src/main/resources/com/deeme/lang/strings_hu.properties
src/main/resources/com/deeme/lang/strings_it.properties
src/main/resources/com/deeme/lang/strings_lt.properties
src/main/resources/com/deeme/lang/strings_pl.properties
src/main/resources/com/deeme/lang/strings_pt.properties
src/main/resources/com/deeme/lang/strings_ro.properties
src/main/resources/com/deeme/lang/strings_ru.properties
src/main/resources/com/deeme/lang/strings_sv.properties
src/main/resources/com/deeme/lang/strings_tr.properties
src/main/resources/com/deeme/lang/strings_uk.properties

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've found 1 issue, and left some high level feedback:

  • The new quest_module.manual_quests strings are added identically in English across all locale files; if these are intended for translation rather than fallback, consider either adding localized text or leaving them only in the base language file until translations are available.
  • The description text It even takes on quest it doesn't know how to do, and when it reaches a condition it doesn't know, it will disconnect so you can do it manually. is a bit awkward grammatically; consider rephrasing for clarity (e.g., It will also accept quests it doesn't know how to complete, and when it encounters an unknown condition, it will disconnect so you can finish it manually).
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- The new `quest_module.manual_quests` strings are added identically in English across all locale files; if these are intended for translation rather than fallback, consider either adding localized text or leaving them only in the base language file until translations are available.
- The description text `It even takes on quest it doesn't know how to do, and when it reaches a condition it doesn't know, it will disconnect so you can do it manually.` is a bit awkward grammatically; consider rephrasing for clarity (e.g., `It will also accept quests it doesn't know how to complete, and when it encounters an unknown condition, it will disconnect so you can finish it manually`).

## Individual Comments

### Comment 1
<location> `src/main/resources/com/deeme/lang/strings_es.properties:465` </location>
<code_context>
 quest_module.quest_types_to_do=Type of quests to do
 quest_module.quest_types_to_do.desc=Select the types of quests that the module should do
+quest_module.manual_quests=Unknown conditions
+quest_module.manual_quests.desc=It even takes on quest it doesn't know how to do, and when it reaches a condition it doesn't know, it will disconnect so you can do it manually.

 urgent_detector=Urgent quests detector
</code_context>

<issue_to_address>
**nitpick (typo):** Minor grammar issue in the English description string.

The phrase "It even takes on quest it doesn't know how to do" is ungrammatical. Please change it to either "It even takes on quests it doesn't know how to do" or "It even takes on a quest it doesn't know how to do" for clarity.
</issue_to_address>

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

quest_module.quest_types_to_do=Tipo de misiones a hacer
quest_module.quest_types_to_do.desc=Seleccione los tipos de misiones que el módulo debe hacer
quest_module.manual_quests=Unknown conditions
quest_module.manual_quests.desc=It even takes on quest it doesn't know how to do, and when it reaches a condition it doesn't know, it will disconnect so you can do it manually.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick (typo): Minor grammar issue in the English description string.

The phrase "It even takes on quest it doesn't know how to do" is ungrammatical. Please change it to either "It even takes on quests it doesn't know how to do" or "It even takes on a quest it doesn't know how to do" for clarity.

@dm94 dm94 merged commit 38ddf0d into master Dec 26, 2025
8 checks passed
@dm94 dm94 deleted the l10n_master branch December 26, 2025 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants