cli/command: PruneFilters: slight cleanup #5946
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thaJeztah
added
status/2-code-review
kind/refactor
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5946 +/- ##
==========================================
- Coverage 59.47% 59.45% -0.02%
==========================================
Files 357 357
Lines 29744 29744
==========================================
- Hits 17690 17685 -5
- Misses 11090 11094 +4
- Partials 964 965 +1 🚀 New features to boost your workflow:
|
- remove pruneFilters.Contains for checks, as this is already handled by pruneFilters.ExactMatch. - Update GoDoc to better describe the function's functionality - Use a swtich instead of if/else. This function should be moved to a separate package; possibly splitting it out to a "Merge" function that accepts two filter.Args as argument. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
prunefilter_cleanup
branch
from
5a9ab71 to
d97f65c
Compare
Benehiko
approved these changes
Apr 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function should be moved to a separate package; possibly splitting it out to a "Merge" function that accepts two filter.Args as argument.
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)