cli/command/registry: loginClientSide: use locally defined message #5958
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thaJeztah
added
status/2-code-review
kind/refactor
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5958 +/- ##
=======================================
Coverage 59.09% 59.09%
=======================================
Files 354 354
Lines 29733 29733
=======================================
Hits 17572 17572
Misses 11191 11191
Partials 970 970 🚀 New features to boost your workflow:
|
thaJeztah
force-pushed
the
login_message
branch
from
52ad585 to
f5f7c5b
Compare
The "Service.Auth" pretended to return a message from the registry, but the message returned is hard-coded in the registry package. Remove its use to make this more transparent, and not to pretend this is anything returned by the registry. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
login_message
branch
from
f5f7c5b to
1a14abb
Compare
thaJeztah
commented
Mar 25, 2025
|
|
||
| return ®istrytypes.AuthenticateOKBody{ | ||
| Status: status, | ||
| Status: "Login Succeeded", |
Member
Author
There was a problem hiding this comment.
We could consider printing a different message if authentication happened client-side (not through the docker engine API); leaving that for something to consider after this.
vvoland
approved these changes
Mar 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "Service.Auth" pretended to return a message from the registry, but the message returned is hard-coded in the registry package.
Remove its use to make this more transparent, and not to pretend this is anything returned by the registry.
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)