cli/context/store: un-export LimitedReader #5982
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was created for internal use, and is not part of the context-store public API. It was introduced as part of the "zip import" functionality added in 291e862. Initially it was [non-exported][1], but during review, some suggestions were made to improve the implementation, and the [suggested implementation][2] was based on Go stdlib, but review overlooked that the implementation was now exported. Let's un-export it, as this was (as outlined) never meant to be a public type. [1]: docker#1895 (comment) [2]: docker#1895 (comment) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
added
status/2-code-review
area/context
kind/refactor
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5982 +/- ##
==========================================
- Coverage 59.12% 59.10% -0.02%
==========================================
Files 355 355
Lines 29740 29740
==========================================
- Hits 17583 17578 -5
- Misses 11182 11188 +6
+ Partials 975 974 -1 🚀 New features to boost your workflow:
|
Benehiko
approved these changes
Apr 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relates to
It was created for internal use, and is not part of the context-store public API. It was introduced as part of the "zip import" functionality added in 291e862. Initially it was non-exported, but during review, some suggestions were made to improve the implementation, and the suggested implementation was based on Go stdlib, but review overlooked that the implementation was now exported.
Let's un-export it, as this was (as outlined) never meant to be a public type.
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)