Skip to content

Conversation

@vvoland
Copy link
Collaborator

@vvoland vvoland commented Apr 11, 2025

full diff: moby/moby@511cd1c...250792c

Signed-off-by: Paweł Gronowski pawel.gronowski@docker.com

@vvoland vvoland added this to the 28.1.0 milestone Apr 11, 2025
@vvoland vvoland self-assigned this Apr 11, 2025
@vvoland vvoland requested review from Benehiko and thaJeztah April 11, 2025 11:53
@codecov-commenter
Copy link

codecov-commenter commented Apr 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.10%. Comparing base (07b203e) to head (ec9e729).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6002   +/-   ##
=======================================
  Coverage   59.10%   59.10%           
=======================================
  Files         356      356           
  Lines       29813    29813           
=======================================
  Hits        17621    17621           
  Misses      11216    11216           
  Partials      976      976           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@vvoland
Copy link
Collaborator Author

vvoland commented Apr 11, 2025

Hmm, looks like the golden files need update due to: moby/moby#49783

@thaJeztah can you PTAL?

@thaJeztah
Copy link
Member

Something's broken. It looks like it doesn't like "template" combined with the custom Marshal function. Perhaps because there's some additional nesting happening in the CLI 🤔

=== RUN   TestPrettyPrintInfo
=== RUN   TestPrettyPrintInfo/errors_for_both
    info_test.go:387: assertion failed: error is not nil: template: :1:2: executing "" at <json .>: error calling json: runtime error: invalid memory address or nil pointer dereference
--- FAIL: TestPrettyPrintInfo/errors_for_both (0.00s)

@thaJeztah
Copy link
Member

@vvoland let's revert that one for now; we can re-apply if we figure out what's wrong, but need to dig in a bit to see where it's actually failing;

full diff: moby/moby@511cd1c...250792c

Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
@vvoland vvoland changed the title vendor: github.com/docker/docker v28.1.0-dev (73520a5ab71d) vendor: github.com/docker/docker v28.1.0-dev (250792c1a540) Apr 11, 2025
@vvoland
Copy link
Collaborator Author

vvoland commented Apr 11, 2025

Flaky?

65.51 === Failed
65.51 === FAIL: cli/command TestInitializeFromClientHangs (1.00s)
65.51     cli_test.go:252: server never received an init request

@vvoland
Copy link
Collaborator Author

vvoland commented Apr 11, 2025

@thaJeztah This one is ready

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah thaJeztah merged commit 559c012 into docker:master Apr 11, 2025
93 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants