-
Notifications
You must be signed in to change notification settings - Fork 2.1k
vendor: github.com/docker/docker v28.1.0-dev (250792c1a540) #6002
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6002 +/- ##
=======================================
Coverage 59.10% 59.10%
=======================================
Files 356 356
Lines 29813 29813
=======================================
Hits 17621 17621
Misses 11216 11216
Partials 976 976 🚀 New features to boost your workflow:
|
|
Hmm, looks like the golden files need update due to: moby/moby#49783 @thaJeztah can you PTAL? |
|
Something's broken. It looks like it doesn't like "template" combined with the custom Marshal function. Perhaps because there's some additional nesting happening in the CLI 🤔 |
|
@vvoland let's revert that one for now; we can re-apply if we figure out what's wrong, but need to dig in a bit to see where it's actually failing; |
full diff: moby/moby@511cd1c...250792c Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
|
Flaky? |
|
@thaJeztah This one is ready |
thaJeztah
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
full diff: moby/moby@511cd1c...250792c
Signed-off-by: Paweł Gronowski pawel.gronowski@docker.com