quote some variables, and use double-quotes for more readable output #449
+6
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed some variables weren't quoted but included parts that could be set through environment variables. Add quotes to those to prevent possible issues, and use double quotes to make the output more readable, similar to what was done in commit 65cca2f Before: + TMP_REPO_FILE=/tmp/tmp.gg8DOiskXT + sh -c 'curl -fsSL '\''https://download.docker.com/linux/fedora/docker-ce.repo'\'' | tr -s '\''\n'\'' > '\''/tmp/tmp.gg8DOiskXT'\''' + sh -c 'dnf5 config-manager addrepo --save-filename=docker-ce.repo --overwrite --from-repofile='\''/tmp/tmp.gg8DOiskXT'\''' + sh -c 'rm -f '\''/tmp/tmp.gg8DOiskXT'\''' After: + TMP_REPO_FILE=/tmp/tmp.C89hwiQBFk + sh -c 'curl -fsSL "https://download.docker.com/linux/fedora/docker-ce.repo" | tr -s "\n" > "/tmp/tmp.C89hwiQBFk"' + sh -c 'dnf5 config-manager addrepo --save-filename=docker-ce.repo --overwrite --from-repofile="/tmp/tmp.C89hwiQBFk"' + sh -c 'rm -f "/tmp/tmp.C89hwiQBFk"' Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed some variables weren't quoted but included parts that could be set through environment variables.
Add quotes to those to prevent possible issues, and use double quotes to make the output more readable, similar to what was done in commit 65cca2f
Before:
After: