최예린 1주차 과제 #8
Open
최예린 1주차 과제 #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjunhub
reviewed
Oct 2, 2024
Comment on lines
+85
to
+89
| PrizeWinner findWinner1 = prizeWinnerRepository.findByNameAndItem("고길동","10만원"); | ||
| PrizeWinner findWinner2 = prizeWinnerRepository.findByNameAndItem("김머머","50만원"); | ||
|
|
||
| Assertions.assertThat(findWinner1.getName()).isEqualTo("고길동"); | ||
| Assertions.assertThat(findWinner2.getEmail()).isEqualTo("qwer@ajou.ac.kr"); |
Member
There was a problem hiding this comment.
깔끔하게 잘 해내신 것 같습니다.
아래처럼 존재하지 않는 경우도 테스트케이스에 넣으면 좋을것 같습니다.
Suggested change
| PrizeWinner findWinner1 = prizeWinnerRepository.findByNameAndItem("고길동","10만원"); | |
| PrizeWinner findWinner2 = prizeWinnerRepository.findByNameAndItem("김머머","50만원"); | |
| Assertions.assertThat(findWinner1.getName()).isEqualTo("고길동"); | |
| Assertions.assertThat(findWinner2.getEmail()).isEqualTo("qwer@ajou.ac.kr"); | |
| PrizeWinner findWinner1 = prizeWinnerRepository.findByNameAndItem("고길동","10만원"); | |
| PrizeWinner findWinner2 = prizeWinnerRepository.findByNameAndItem("김머머","50만원"); | |
| PrizeWinner findWinner3 = prizeWinnerRepository.findByNameAndItem("스프링","30만원"); // null | |
| Assertions.assertThat(findWinner1.getName()).isEqualTo("고길동"); | |
| Assertions.assertThat(findWinner2.getEmail()).isEqualTo("qwer@ajou.ac.kr"); | |
| Assertions.assertThat(findWinner3).isNull(); |
수고하셨습니다!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
당첨자 관리 데이터베이스 테이블