Skip to content

Fix alerts component #352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
leoj3n wants to merge 1 commit into
base: staging
Choose a base branch
from
Open

Fix alerts component #352

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions public/components/ui/alerts/alerts.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import Kefir from 'kefir';
import Kefir from 'can-kefir';
import canStream from 'can-stream-kefir';
import canDefineStreamKefir from 'can-define-stream-kefir';
import Component from 'can-component';
Expand Down Expand Up @@ -35,7 +35,6 @@ const ViewModel = DefineMap.extend({
.merge(this.autoHideStream)
.merge(this.stream('remove'))
.scan((alerts, ev) => {
console.log("GOt event", ev.type);
switch (ev.type) {
case 'alert':
return [ev, ...alerts.slice()];
Expand Down
4 changes: 2 additions & 2 deletions public/components/ui/alerts/alerts.stache
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,11 @@
<div class="alert-container">
{{# each(alerts) }}
<div class="alert alert-dismissable alert-{{ kind }}">
<button type="button" class="close" on:click="removeAlert(.)">
<button type="button" class="close" on:click="../removeAlert(.)">
<span aria-hidden="true">&times;</span>
</button>
{{# title }}<h3 class="title">{{ . }}</h3>{{/ title }}
{{# message }}<div class="message">{{ {. }}}</div>{{/ message }}
{{# message }}<div class="message">{{{ . }}}</div>{{/ message }}
</div>
{{/ each }}
</div>
2 changes: 1 addition & 1 deletion public/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@
"can-define-stream-kefir": "^1.0.0",
"can-event-dom-enter": "^2.1.2",
"can-event-queue": "^1.0.2",
"can-kefir": "^1.1.0",
"can-observation": "^4.0.1",
"can-query-logic": "<2.0.0",
"can-queues": "^1.1.0",
Expand Down Expand Up @@ -91,7 +92,6 @@
"feathers-socketio": "1.4.2",
"jquery": "^2.1.4",
"jwt-decode": "^2.1.0",
"kefir": "^3.6.1",
"moment": "^2.17.0",
"steal": "^1.12.1",
"steal-css": "^1.0.0",
Expand Down