Update samples to .NET 9 #5882
Update samples to .NET 9 #5882
Conversation
ghost
added
|
I'll defer #5113 to a follow-up PR since this PR is big enough already - this is ready for review. |
| <?xml version="1.0" encoding="utf-8"?> | ||
| <configuration> | ||
| <packageSources> | ||
| <clear /> |
There was a problem hiding this comment.
Removing this will trigger an alert. All NuGet.config files need to have a <clear /> element to avoid implicit feed to nuget.org.
There was a problem hiding this comment.
I removed it because for the purposes of this sample, users probably won't want to use our nuget.org mirror - since it doesn't have all packages and others can be several versions behind.
There was a problem hiding this comment.
We determined with #5787 that using NuGet.org for the purpose of validating user scenarios is acceptable.
|
I'm working on getting the manifest.samples.json to work with the build matrix generation now. It's creating some duplicate legs since we've got 8.0 and 9.0 samples now. @mthalman, @richlander, @MichaelSimons, any other feedback on the actual samples content? |
|
The markdown link check failures are due to #5872 (comment) (not an actual issue with this PR). They would be fixed by dotnet/docker-tools#1446. |
2 participants
Related
Updates
samples/8.0