Skip to content

Fix FromStagingPipelineCommand creating internal-versions.txt without --internal flag #6927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Copilot wants to merge 2 commits into
base: nightly
Choose a base branch
from
Open

Fix FromStagingPipelineCommand creating internal-versions.txt without --internal flag #6927

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7754ce0
Initial plan
Copilot Jan 13, 2026
63dfbde
Fix: Only record internal-versions.txt when --internal flag is used
Copilot Jan 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions eng/update-dependencies/FromStagingPipelineCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,11 +70,14 @@ public override async Task<int> ExecuteAsync(FromStagingPipelineOptions options)
DotNetVersion dotNetVersion = DotNetVersion.Parse(releaseConfig.RuntimeBuild);
string majorMinorVersionString = dotNetVersion.ToString(2);

// Record pipeline run ID for this internal version, for later use by sync-internal-release command
_internalVersionsService.RecordInternalStagingBuild(
repoRoot: gitRepoContext.LocalRepoPath,
dotNetVersion: dotNetVersion,
stagingPipelineRunId: options.StagingPipelineRunId);
if (options.Internal)
{
// Record pipeline run ID for this internal version, for later use by sync-internal-release command
_internalVersionsService.RecordInternalStagingBuild(
repoRoot: gitRepoContext.LocalRepoPath,
dotNetVersion: dotNetVersion,
stagingPipelineRunId: options.StagingPipelineRunId);
}

var productVersions = (options.Internal, releaseConfig.SdkOnly) switch
{
Expand Down