feat: add sorting to the API #6
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
draganm
requested changes
Feb 23, 2023
Owner
draganm
left a comment
draganm
left a comment
There was a problem hiding this comment.
please add validation for sort query, allow only asc and desc.
draganm
approved these changes
Feb 23, 2023
draganm
requested changes
Mar 16, 2023
| var errTimeout = errors.New("timeout") | ||
|
|
||
| func (c *Client) PollForEvents(ctx context.Context, lastID string, limit int, evts any) ([]string, error) { | ||
| func (c *Client) PollForEvents(ctx context.Context, lastID string, limit int, sort string, evts any) ([]string, error) { |
Owner
There was a problem hiding this comment.
think the interface is not really clear. How about adding either a type Order with two const values, or passing a boolean ascending. Sting allows for way too many 'wrong' values to be passed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.