Skip to content

Conversation

@ZanattaMichael
Copy link

@ZanattaMichael ZanattaMichael commented Oct 18, 2021

Pull Request (PR) description

Task list

  • Added an entry under the Unreleased section of the change log in the CHANGELOG.md.
    Entry should say what was changed, and how that affects users (if applicable).
  • Resource documentation added/updated in README.md in resource folder.
  • Resource parameter descriptions added/updated in schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Resource Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
  • New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

This change is Reviewable

@ZanattaMichael
Copy link
Author

Hi There! I'm just following up on this PR to see if I need to make any changes.

Thanks!

Michael.

@gaelcolas
Copy link
Member

@nyanhp or @raandree any chance you can check this PR pretty please :)

@gaelcolas gaelcolas requested a review from raandree December 10, 2021 20:55
@raandree
Copy link

raandree commented May 7, 2022

Sorry for the huge delay, I will take care of this very soon.

@johlju johlju added the needs review The pull request needs a code review. label May 8, 2022
@codecov
Copy link

codecov bot commented May 11, 2022

Codecov Report

Merging #50 (2cce90f) into master (7608302) will decrease coverage by 0%.
The diff coverage is 0%.

Impacted file tree graph

@@         Coverage Diff          @@
##           master   #50   +/-   ##
====================================
- Coverage      35%   35%   -1%     
====================================
  Files           5     5           
  Lines         445   456   +11     
====================================
  Hits          160   160           
- Misses        285   296   +11     
Impacted Files Coverage Δ
source/Classes/1.SessionConfigurationUtility.ps1 0% <0%> (ø)
source/Classes/JeaSessionConfiguration.ps1 0% <0%> (ø)

@ZanattaMichael
Copy link
Author

Hi @raandree. What needs to be done with this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs review The pull request needs a code review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants