CSS Grid for staff_semester_view & grades_semester_view #2534
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
There was a problem hiding this comment.
this seems very excessive, I would hope that there is an easier way to set up something similar; either way, let's discuss this in #2046
Member
There was a problem hiding this comment.
Also, for the sake of being able to review and merge stuff, please separate the "frontend looks testing" and the "CSS grid" portions here into at least two separate PRs
fekoch
force-pushed
the
2352/use-css-grid-everywhere
branch
3 times, most recently
from
51822fc to
ab19fc3
Compare
fekoch
force-pushed
the
2352/use-css-grid-everywhere
branch
from
ab19fc3 to
927acda
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #2352
done:
in progress: