Feat/fix callback type checks #4
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR 描述
概述
此PR在UI组件的回调函数中添加了安全检查，以防止在将非函数类型传递给回调参数时出现运行时错误。
更改内容
对三个文件进行了修改，在回调函数执行前添加类型检查：
packages/react-native-chat-uikit/src/biz/hooks/useCloseAlert.tsx- 添加typeof onFinished === 'function'检查packages/react-native-chat-uikit/src/biz/hooks/useCloseMenu.tsx- 添加typeof onFinished === 'function'检查packages/react-native-chat-uikit/src/ui/Modal/SlideModal.tsx- 添加typeof onf === 'function'检查，并恢复了有关性能优化的注释代码动机
防止因传入非函数类型的回调参数而导致的运行时错误，提高组件的健壮性。