Skip to content

Conversation

@timoconnellaus
Copy link

This happens when you switch from isEditing false to true. The sidebar appears and can sometimes overlap the canvas.

This triggers a rerender of the viewport after changing editing state so the canvas will fit correctly

…'t hide behind the sidebar until screen is resized
@vercel
Copy link

vercel bot commented May 22, 2024

@timoconnellaus is attempting to deploy a commit to the Shopstory Team on Vercel.

A member of the Team first needs to authorize it.

@r00dY
Copy link
Contributor

r00dY commented May 22, 2024

Can you please provide an info how to reproduce it? The EditorContent has isEditing state variable so it should re-render anyway.

@timoconnellaus
Copy link
Author

To replicate:

  1. Open the editor
  2. Use desktop size
  3. Resize browser so that the canvas has no space on the left and right (touching the edges)
  4. switch edit mode off then back on again
  5. The canvas should now be behind the sidebar
  6. You should now need to resize the browser window to trigger the canvas to reset to not be behind the

Note that this is more prominent with the PR #53 because it appears above the left sidebar (not below like the right sidebar)

@r00dY
Copy link
Contributor

r00dY commented May 24, 2024

will check this out on Monday

@r00dY
Copy link
Contributor

r00dY commented May 27, 2024

I made it so that there's only one re-renderer here: #55. Thoughts?

@timoconnellaus
Copy link
Author

You're the expert @r00dY. Looks good to me!

@r00dY
Copy link
Contributor

r00dY commented May 29, 2024

Implemented and merged here: #55

@r00dY r00dY closed this May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants