Fix clippy lints in tests #141
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Happy to merge as is, but also happy to add clippy to the lint job as well. Up to you. |
Contributor
Author
|
I'd merge this for now, and I'll maybe get to the CI tweak at the weekend (no reason why it can't be a seperate PR), cheers! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Something I noticed while working on #140 when I wanted to make sure the macro invocations weren't producing lints. For the unaware, clippy doesn't check code in
#[cfg(test)]by default unless you pass the--testsflag, at which point I noticed several errors in existing codeI also noticed that clippy isn't being run as part of the GitHub workflow, which I could add as part of the lint job if you'd like :)