Skip to content

Make NodeChildProcessImplementation::exec properly wait on the exec call #1984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
RossBrunton wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Make NodeChildProcessImplementation::exec properly wait on the exec call #1984

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/providers/node/child_process/ChildProcessImplementation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ export const NodeChildProcessImplementation: NodeChildProcessProvider = {
exec: async (path, options, callback) => {
// Error is passed directly into resolve to keep compatibility with callback implementations.
// Therefore no need to use a `.catch` block
window.node.child_process.exec(path, options)
await window.node.child_process.exec(path, options)
.then(err => {
if (callback) {
callback(err as unknown as Error);
Expand Down