-
Notifications
You must be signed in to change notification settings - Fork 6
Queries migration to SDK & Configurability #554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dkildar
wants to merge
43
commits into
develop
Choose a base branch
from
feature/queries-migration
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gration # Conflicts: # apps/web/src/api/queries/engine/index.ts
- Resolved conflicts from migrated queries (notifications, hive-engine, stats) - Updated imports to use SDK and wallets packages - Updated package versions (SDK 1.3.6, Wallets 1.4.35) - Rebuilt packages to regenerate dist files
- Added Entry, Vote, and related types to SDK posts module - Migrated 4 core post queries to SDK: * get-entry-active-votes-query * get-post-header-query * get-post-query * get-discussions-query - Includes sorting logic and parseAsset utility - All queries use CONFIG.hiveClient for bridge API calls - Rebuilt SDK package (v1.3.7)
- Added getAccountPostsInfiniteQueryOptions for account posts - Added getPostsRankedInfiniteQueryOptions for ranked/feed posts - Added getReblogsQueryOptions for reblog data - Includes BlogEntry and Reblog types - All use Hive bridge/condenser API calls - Fixed TypeScript types for query keys - Rebuilt SDK package
Updated 7 query wrappers to use SDK query options: - get-post-query → uses getPostQueryOptions from SDK - get-post-header-query → uses getPostHeaderQueryOptions - get-entry-active-votes-query → uses getEntryActiveVotesQueryOptions - get-discussions-query → uses getDiscussionsQueryOptions - get-account-posts-query → uses getAccountPostsInfiniteQueryOptions - get-posts-ranked-query → uses getPostsRankedInfiniteQueryOptions - get-reblogs-query → uses getReblogsQueryOptions Maintains backward compatibility by wrapping SDK queries with EcencyQueriesManager to preserve existing API (.prefetch, .getData, etc.) Preserves app-specific logic: - Cache management for discussions (EcencyEntriesCacheManagement) - SortOrder enum mapping between app and SDK - Active user context for reblogs
…ry.tsx Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
…ns-settings-query-options.ts Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
…ns-unread-count-query-options.ts Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
…ns.tsx Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
…-options.ts Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Member
|
We still have wrappers and footprint from old queries, creating standard use of react query and cleanup wrappers should be next step, imo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
New Features
Improvements
Bug Fixes
✏️ Tip: You can customize this high-level summary in your review settings.