Add setAutoscaleDisabled API to provide a better means to disabling autoscaling at widget level #2863

amartya4256 · 2025-12-09T13:08:39Z

This PR provides a new API setAutoscaleDisabled to provide a better means of disabling autoscaling at widget level across all the platforms. The current implementation is intended to return a false when this method is called in cocoa and GTK and only perform an action win32 and return since we do not support widget level autoscaling control on GTK and cocoa yet.

The convention of the method is as follows:

Takes a boolean parameter for disabling or enabling autoscale
returns true if successful (in case of win32) otherwise false (in case of GTK and cocoa)

Things to be done:

Usage of different autoscaling modes as enabled, disabled and disabled_cascaded, etc
Testing with GEF to see how it impacts.

depends on #2930

eclipse-platform-bot · 2025-12-09T13:14:52Z

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

binaries/org.eclipse.swt.win32.win32.x86_64/META-INF/MANIFEST.MF

Warning

🚧 This PR cannot be modified by maintainers because edits are disabled or it is created from an organization repository. To obtain the required changes apply the git patch manually as an additional commit.

Git patch

From 985988b5290c07034647310b3fdbf3bbb5212354 Mon Sep 17 00:00:00 2001
From: Eclipse Platform Bot <platform-bot@eclipse.org>
Date: Tue, 30 Dec 2025 08:42:22 +0000
Subject: [PATCH] Version bump(s) for 4.39 stream


diff --git a/binaries/org.eclipse.swt.win32.win32.x86_64/META-INF/MANIFEST.MF b/binaries/org.eclipse.swt.win32.win32.x86_64/META-INF/MANIFEST.MF
index 84f618f2b6..3dccebb562 100644
--- a/binaries/org.eclipse.swt.win32.win32.x86_64/META-INF/MANIFEST.MF
+++ b/binaries/org.eclipse.swt.win32.win32.x86_64/META-INF/MANIFEST.MF
@@ -3,7 +3,7 @@ Fragment-Host: org.eclipse.swt;bundle-version="[3.128.0,4.0.0)"
 Bundle-Name: %fragmentName
 Bundle-Vendor: %providerName
 Bundle-SymbolicName: org.eclipse.swt.win32.win32.x86_64; singleton:=true
-Bundle-Version: 3.132.0.qualifier
+Bundle-Version: 3.132.100.qualifier
 Bundle-ManifestVersion: 2
 Bundle-Localization: fragment
 Export-Package: 
-- 
2.52.0

Further information are available in Common Build Issues - Missing version increments.

github-actions · 2025-12-09T13:23:51Z

Test Results

176 files ±0 176 suites ±0 26m 55s ⏱️ +41s
4 672 tests ±0 4 650 ✅ ±0 22 💤 ±0 0 ❌ ±0
482 runs ±0 476 ✅ ±0 6 💤 ±0 0 ❌ ±0

Results for commit 85a74d1. ± Comparison against base commit 383ed2a.

♻️ This comment has been updated with latest results.

HeikoKlare · 2025-12-09T14:16:39Z

@amartya4256 can you please add a meaningful title and description to the PR, even if it's still a draft?

bundles/org.eclipse.swt/Eclipse SWT/cocoa/org/eclipse/swt/widgets/Control.java

HeikoKlare · 2026-01-05T12:31:07Z

bundles/org.eclipse.swt/Eclipse SWT/cocoa/org/eclipse/swt/widgets/Shell.java

+ *
+ * @since 3.133
+ */
+public int getNativeZoom() {


In my opinion, we should call this getZoom(), as consumers should not bother with native/non-native zoms. And the effective zoom of a shell to deal with is always the native zoom, isn't it?

That is not always true. When autoscaling is disabled getZoom returns autoscaled zoom depending on the scaling mode i.e. quarter, half, etc. Hence to do so, we need to rename the internal method getZoom to getAutoscaledZoom and then call this API Shell#getZoom. I'll create a separate PR.

HeikoKlare · 2026-01-05T12:33:40Z

bundles/org.eclipse.swt/Eclipse SWT/common/org/eclipse/swt/graphics/AutoscalingMode.java

+ *   <li><b>{@link #DISABLED_INHERITED}</b> – Autoscaling is disabled for this
+ *       component, but the decision originates from a parent or owner context.
+ *       This is typically used to indicate that the disabled state was not set
+ *       explicitly at this level but inherited from upstream configuration.</li>


Don't we need a mode to set on a control that the autoscale mode will (not) be inherited to childred of the control rather than to indicate that a control has inherited the mode? Since it's only used in a setter, how should the current semantics be reasonably applied anyway? And isn't that even how it is currently implemented?

bundles/org.eclipse.swt/Eclipse SWT/common/org/eclipse/swt/graphics/AutoscalingMode.java

This commit renames the method Widget#getZoom to getAutoscalingZoom since this methods return the value of the zoom based on the autoscaling technique, i.e. quarter, half, etc and whether autoscaling is enabled or disabled.

github-actions · 2026-01-06T13:07:26Z

Test Results (macos)

54 files ±0 54 suites ±0 8m 55s ⏱️ + 2m 6s
4 513 tests ±0 4 270 ✅ ±0 243 💤 ±0 0 ❌ ±0
104 runs ±0 104 ✅ ±0 0 💤 ±0 0 ❌ ±0

Results for commit ddd5eab. ± Comparison against base commit 892be33.

♻️ This comment has been updated with latest results.

This commit adds an API to set Autoscaling Modes using the new enum AutoscalingMode with types Enabled, Disabled and Disabled_Inherited. Moreover, it also provides an API Shell#getNativeZoom to still make the consumer be able to obtain the actual zoom at a screen. These features are only enabled on win32 and will not perform any action on other platforms if called.

amartya4256 changed the title ~~WIP~~ Add setAutoscaleDisabled API to provide a better means to disabling autoscaling at widget level Dec 9, 2025

amartya4256 linked an issue Dec 9, 2025 that may be closed by this pull request

Wrong zoom taken for system metrics in autoscale-disabled controls/scrollables vi-eclipse/Eclipse-Platform#546

Open

arunjose696 mentioned this pull request Dec 17, 2025

[Concept] Proper implementation of autoscale disablement for part of the application vi-eclipse/Eclipse-Platform#345

Open

akoch-yatta removed a link to an issue Dec 19, 2025

Wrong zoom taken for system metrics in autoscale-disabled controls/scrollables vi-eclipse/Eclipse-Platform#546

Open

amartya4256 linked an issue Dec 19, 2025 that may be closed by this pull request

[Concept] Proper implementation of autoscale disablement for part of the application vi-eclipse/Eclipse-Platform#345

Open

amartya4256 force-pushed the amartya4256/set_autoscale_disabled_api branch 2 times, most recently from cb3cc53 to 2a1545f Compare December 23, 2025 09:44

akoch-yatta force-pushed the amartya4256/set_autoscale_disabled_api branch from 2a1545f to f5b90b2 Compare December 30, 2025 08:38

amartya4256 force-pushed the amartya4256/set_autoscale_disabled_api branch 7 times, most recently from 8ff51cb to 85a74d1 Compare January 2, 2026 13:58

amartya4256 marked this pull request as ready for review January 2, 2026 14:16

HeikoKlare reviewed Jan 5, 2026

View reviewed changes

amartya4256 force-pushed the amartya4256/set_autoscale_disabled_api branch from 85a74d1 to d858871 Compare January 6, 2026 12:44

Renamed Widget#getZoom to getAutoscalingZoom

b2b17db

This commit renames the method Widget#getZoom to getAutoscalingZoom since this methods return the value of the zoom based on the autoscaling technique, i.e. quarter, half, etc and whether autoscaling is enabled or disabled.

amartya4256 force-pushed the amartya4256/set_autoscale_disabled_api branch from d858871 to 2c97d55 Compare January 6, 2026 13:17

amartya4256 force-pushed the amartya4256/set_autoscale_disabled_api branch from 2c97d55 to ddd5eab Compare January 6, 2026 13:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add setAutoscaleDisabled API to provide a better means to disabling autoscaling at widget level #2863

Add setAutoscaleDisabled API to provide a better means to disabling autoscaling at widget level #2863

amartya4256 commented Dec 9, 2025 •

edited

Loading

Uh oh!

eclipse-platform-bot commented Dec 9, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Dec 9, 2025 •

edited

Loading

Uh oh!

HeikoKlare commented Dec 9, 2025

Uh oh!

Uh oh!

Uh oh!

HeikoKlare Jan 5, 2026

Uh oh!

amartya4256 Jan 6, 2026

Uh oh!

amartya4256 Jan 6, 2026

Uh oh!

HeikoKlare Jan 5, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Jan 6, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Add setAutoscaleDisabled API to provide a better means to disabling autoscaling at widget level #2863

Are you sure you want to change the base?

Add setAutoscaleDisabled API to provide a better means to disabling autoscaling at widget level #2863

Conversation

amartya4256 commented Dec 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

eclipse-platform-bot commented Dec 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Dec 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results

Uh oh!

HeikoKlare commented Dec 9, 2025

Uh oh!

Uh oh!

Uh oh!

HeikoKlare Jan 5, 2026

Choose a reason for hiding this comment

Uh oh!

amartya4256 Jan 6, 2026

Choose a reason for hiding this comment

Uh oh!

amartya4256 Jan 6, 2026

Choose a reason for hiding this comment

Uh oh!

HeikoKlare Jan 5, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Jan 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results (macos)

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

amartya4256 commented Dec 9, 2025 •

edited

Loading

eclipse-platform-bot commented Dec 9, 2025 •

edited

Loading

github-actions bot commented Dec 9, 2025 •

edited

Loading

github-actions bot commented Jan 6, 2026 •

edited

Loading