Disposing and recreating menus menus when parent changes #3610
+13
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Test Results 3 015 files ±0 3 015 suites ±0 2h 9m 34s ⏱️ - 6m 23s For more details on these failures, see this check. Results for commit 34a73de. ± Comparison against base commit 93acda3. ♻️ This comment has been updated with latest results. |
ShahzaibIbrahim
approved these changes
Dec 24, 2025
Contributor
ShahzaibIbrahim
left a comment
ShahzaibIbrahim
left a comment
There was a problem hiding this comment.
The changes look good to me. Tested with 350% secondary zoom and 250% primary zoom
Menus, unlike controls, were not reparented when their associated part was moved (e.g., dragged to a different monitor). This caused menu icons and images to render at the wrong zoom due to the old parent's DPI. This change checks if a menu's parent has changed during rendering. If so, the menu is disposed and recreated under the correct parent, ensuring proper scaling and visual consistency across monitors.
akoch-yatta
force-pushed
the
arunjose696/529/MenuPartZoom
branch
from
9d11600 to
34a73de
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a part is moved to a different monitor if the part is a control we currently reparent the part As in the this codeblock .
However Menus, unlike controls, were not reparented when their associated part was moved (e.g., dragged to a different monitor). This caused menu icons and images to render at the wrong zoom due to the old parent's DPI.
This change checks if a menu's parent has changed during rendering. If so, the menu is disposed and recreated under the correct parent, ensuring proper scaling and visual consistency across monitors.
Steps to reproduce
1)Start the runtime workspace on secondary monitor (350%)
2)Click on three dots on the right to open the menu here the icons would be rightly sized
2)Drag the Project Explorer tab to primary monitor (150%)
3)Click on three dots on the right
Before
After