Skip to content

Conversation

@MohamedRady-99
Copy link
Contributor

This PR resolves issue #27 by implementing a robust error handling mechanism for activity failures.

Proposal
This change introduces a comprehensive startup error handling mechanism to ensure the system fails gracefully. The implemented behavior is as follows:

  • Error Reporting: Activities can now report a failure from their startup() function by returning a Result. This is critical for handling initialization failures like resource allocation errors.
  • Error Propagation: The error is propagated from the Activity through its Worker up to the central Scheduler.
  • Graceful Shutdown: Upon receiving a startup error, the Scheduler:
  1. Immediately aborts the startup sequence for any remaining activities.
  2. Initiates a graceful shutdown for only the activities that have already started successfully.
  3. Terminates the primary process and all associated agents.

Thanks

@github-actions
Copy link

github-actions bot commented Dec 9, 2025

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run //:license-check

Status: ⚠️ Needs Review

Click to expand output
[License Check Output]
Starting local Bazel server (8.3.0) and connecting to it...
INFO: Invocation ID: 41e2d974-1bb9-488f-a240-971e4795949a
Computing main repo mapping: 
Computing main repo mapping: 
DEBUG: Rule 'rules_boost+' indicated that a canonical reproducible form can be obtained by modifying arguments integrity = "sha256-pZY3kJDKUFN829ZdmWOrWu/MhcmnwKJyhAsIfTbfVPU="
DEBUG: Repository rules_boost+ instantiated at:
  <builtin>: in <toplevel>
Repository rule http_archive defined at:
  /home/runner/.bazel/external/bazel_tools/tools/build_defs/repo/http.bzl:394:31: in <toplevel>
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
WARNING: For repository 'rules_cc', the root module requires module version rules_cc@0.2.8, but got rules_cc@0.2.14 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'googletest', the root module requires module version googletest@1.17.0, but got googletest@1.17.0.bcr.2 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'rules_python', the root module requires module version rules_python@1.4.1, but got rules_python@1.5.1 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
Computing main repo mapping: 
Loading: 
Loading: 4 packages loaded
Loading: 4 packages loaded
    currently loading: 
Analyzing: target //:license-check (5 packages loaded, 0 targets configured)
Analyzing: target //:license-check (5 packages loaded, 0 targets configured)

Analyzing: target //:license-check (81 packages loaded, 9 targets configured)

Analyzing: target //:license-check (88 packages loaded, 9 targets configured)

Analyzing: target //:license-check (150 packages loaded, 2889 targets configured)

Analyzing: target //:license-check (156 packages loaded, 7055 targets configured)

Analyzing: target //:license-check (156 packages loaded, 7055 targets configured)

INFO: Analyzed target //:license-check (159 packages loaded, 9071 targets configured).
[9 / 13] Creating runfiles tree bazel-out/k8-opt-exec-ST-d57f47055a04/bin/external/score_tooling+/dash/tool/formatters/dash_format_converter.runfiles [for tool]; 0s local ... (2 actions, 1 running)
INFO: From Generating Dash formatted dependency file ...:
INFO: Successfully converted 2 packages from Cargo.lock to bazel-out/k8-fastbuild/bin/formatted.txt
INFO: Found 1 target...
Target //:license.check.license_check up-to-date:
  bazel-bin/license.check.license_check
  bazel-bin/license.check.license_check.jar
INFO: Elapsed time: 21.275s, Critical Path: 0.42s
INFO: 13 processes: 4 disk cache hit, 9 internal.
INFO: Build completed successfully, 13 total actions
INFO: Running command line: bazel-bin/license.check.license_check ./formatted.txt <args omitted>
usage: org.eclipse.dash.licenses.cli.Main [-batch <int>] [-cd <url>]
       [-confidence <int>] [-ef <url>] [-excludeSources <sources>] [-help] [-lic
       <url>] [-project <shortname>] [-repo <url>] [-review] [-summary <file>]
       [-timeout <seconds>] [-token <token>]

@github-actions
Copy link

github-actions bot commented Dec 9, 2025

The created documentation from the pull request is available at: docu-html

@MohamedRady-99
Copy link
Contributor Author

Hi @armin-acn, could you please review the PR so we can proceed with merging it?

@MohamedRady-99
Copy link
Contributor Author

Hello @armin-acn, I see that you have approved the PR. Could you please proceed with merging it when convenient?

@masc2023 masc2023 merged commit 20335c3 into eclipse-score:main Dec 17, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants