testing: adding test cases for multiple kvs in cpp #205

Saumya-R · 2026-01-06T06:33:41Z

This PR adds C++ test cases for multiple KVS (Key-Value Store) instances, extending test coverage beyond the existing Rust implementation.

Key Changes:

Extended Python test parametrization to include "cpp" alongside "rust"
Implemented three C++ test scenarios for multiple KVS instances with different configurations
Added helper utilities for KVS parameter parsing and instance creation

github-actions · 2026-01-06T06:34:36Z

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run //:license-check

Status: ⚠️ Needs Review

Click to expand output

[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.3.0) and connecting to it...
INFO: Invocation ID: c7d52e63-0363-4a75-9ee0-970a1f7fc071
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
DEBUG: Rule 'rust_qnx8_toolchain+' indicated that a canonical reproducible form can be obtained by modifying arguments integrity = "sha256-oEubHgeZDdT0svMmBKJx7c3/2TdSI/vfwRUyDn+TPGA="
DEBUG: Repository rust_qnx8_toolchain+ instantiated at:
  <builtin>: in <toplevel>
Repository rule http_archive defined at:
  /home/runner/.bazel/external/bazel_tools/tools/build_defs/repo/http.bzl:394:31: in <toplevel>
Computing main repo mapping: 
Computing main repo mapping: 
Loading: 
Loading: 5 packages loaded
Loading: 5 packages loaded
    currently loading: 
Analyzing: target //:license-check (6 packages loaded, 0 targets configured)
Analyzing: target //:license-check (6 packages loaded, 0 targets configured)

Analyzing: target //:license-check (87 packages loaded, 10 targets configured)

Analyzing: target //:license-check (91 packages loaded, 10 targets configured)

Analyzing: target //:license-check (152 packages loaded, 2946 targets configured)

Analyzing: target //:license-check (162 packages loaded, 3014 targets configured)

INFO: Analyzed target //:license-check (165 packages loaded, 5030 targets configured).
[1 / 11] Creating source manifest for //:license.check.license_check; 0s local
INFO: From Generating Dash formatted dependency file ...:
INFO: Successfully converted 62 packages from Cargo.lock to bazel-out/k8-fastbuild/bin/formatted.txt
INFO: Found 1 target...
Target //:license.check.license_check up-to-date:
  bazel-bin/license.check.license_check
  bazel-bin/license.check.license_check.jar
INFO: Elapsed time: 22.091s, Critical Path: 0.43s
INFO: 14 processes: 5 disk cache hit, 9 internal.
INFO: Build completed successfully, 14 total actions
INFO: Running command line: bazel-bin/license.check.license_check ./formatted.txt <args omitted>
usage: org.eclipse.dash.licenses.cli.Main [-batch <int>] [-cd <url>]
       [-confidence <int>] [-ef <url>] [-excludeSources <sources>] [-help] [-lic
       <url>] [-project <shortname>] [-repo <url>] [-review] [-summary <file>]
       [-timeout <seconds>] [-token <token>]

Copilot

Pull request overview

This PR adds C++ test cases for multiple KVS (Key-Value Store) instances, extending test coverage beyond the existing Rust implementation.

Key Changes:

Extended Python test parametrization to include "cpp" alongside "rust"
Implemented three C++ test scenarios for multiple KVS instances with different configurations
Added helper utilities for KVS parameter parsing and instance creation

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
tests/python_test_cases/tests/test_cit_multiple_kvs.py	Added "cpp" to test parametrization and modified assertions to use rounding for floating-point comparison
tests/cpp_test_scenarios/src/main.cpp	Added CIT test group registration and reformatted code structure
tests/cpp_test_scenarios/src/helpers/kvs_parameters.hpp	New header defining KvsParameters struct for test configuration
tests/cpp_test_scenarios/src/helpers/kvs_parameters.cpp	Implements JSON parsing logic to extract KVS parameters from test input
tests/cpp_test_scenarios/src/helpers/kvs_instance.hpp	New header declaring kvs_instance factory function
tests/cpp_test_scenarios/src/helpers/kvs_instance.cpp	Implements KVS instance builder using parsed parameters
tests/cpp_test_scenarios/src/cit/test_cit_multiple_kvs.hpp	Declares three test scenario classes and group creation function
tests/cpp_test_scenarios/src/cit/test_cit_multiple_kvs.cpp	Implements test scenarios for multiple KVS instances with value setting/retrieval
tests/cpp_test_scenarios/BUILD	Updated build configuration to use glob pattern for source files

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

tests/cpp_test_scenarios/src/cit/test_cit_multiple_kvs.cpp

github-actions · 2026-01-06T06:37:08Z

The created documentation from the pull request is available at: docu-html

Copilot

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-06T08:01:48Z

tests/cpp_test_scenarios/src/main.cpp

 *
 * SPDX-License-Identifier: Apache-2.0
 ********************************************************************************/
+#include <exception>


The <exception> include is unnecessary since std::exception is already available through other includes. Consider removing this redundant include.

Suggested change

#include <exception>

Copilot · 2026-01-06T08:01:49Z

tests/cpp_test_scenarios/src/cit/test_cit_multiple_kvs.cpp

+        auto it2 = obj.find("kvs_parameters_2");
+        if (it1 == obj.end() || it2 == obj.end())
+        {
+            std::cout << "[DEBUG] FINDING Error: " << any_res.error().Message() << std::endl;


The error message accesses any_res.error() even though any_res was successfully parsed at this point (line 149). This will likely cause a runtime error or undefined behavior. The error handling should use a different error message or create a proper error object.

Suggested change

std::cout << "[DEBUG] FINDING Error: " << any_res.error().Message() << std::endl;

std::cout << "[DEBUG] FINDING Error: Missing kvs_parameters_1 or kvs_parameters_2 in parsed JSON object" << std::endl;

Copilot · 2026-01-06T08:01:49Z

tests/cpp_test_scenarios/src/cit/test_cit_multiple_kvs.cpp

+        }
+        catch (const std::exception &e)
+        {
+            throw e;


Re-throwing the caught exception with throw e; causes object slicing and loses the original exception type. Use throw; instead to preserve the exception type.

Suggested change

throw e;

throw;

Copilot · 2026-01-06T08:01:50Z

tests/cpp_test_scenarios/src/cit/test_cit_multiple_kvs.cpp

+        catch (const std::exception &e)
+        {
+
+            throw e;


Re-throwing the caught exception with throw e; causes object slicing and loses the original exception type. Use throw; instead to preserve the exception type.

Suggested change

throw e;

throw;

Saumya-R requested a review from Copilot January 6, 2026 06:33

Copilot AI reviewed Jan 6, 2026

View reviewed changes

Saumya-R added 2 commits January 6, 2026 12:12

testing: adding test cases for multiple kvs in cpp

4045de6

removing redundant variables

d350af5

Saumya-R force-pushed the saumya_multiple_kvs_cpp_testcases branch from 3c7d065 to d350af5 Compare January 6, 2026 06:42

adding copyrights

263500f

Saumya-R requested review from PiotrKorkus and Copilot January 6, 2026 08:01

Copilot AI reviewed Jan 6, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

testing: adding test cases for multiple kvs in cpp #205

testing: adding test cases for multiple kvs in cpp #205

Uh oh!

Saumya-R commented Jan 6, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Jan 6, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Jan 6, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Jan 6, 2026

Uh oh!

Copilot AI Jan 6, 2026

Uh oh!

Copilot AI Jan 6, 2026

Uh oh!

Copilot AI Jan 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

	std::cout << "[DEBUG] FINDING Error: " << any_res.error().Message() << std::endl;
	std::cout << "[DEBUG] FINDING Error: Missing kvs_parameters_1 or kvs_parameters_2 in parsed JSON object" << std::endl;

testing: adding test cases for multiple kvs in cpp #205

Are you sure you want to change the base?

testing: adding test cases for multiple kvs in cpp #205

Uh oh!

Conversation

Saumya-R commented Jan 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Key Changes:

Uh oh!

github-actions bot commented Jan 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

License Check Results

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Jan 6, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Jan 6, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 6, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 6, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 6, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Saumya-R commented Jan 6, 2026 •

edited

Loading

github-actions bot commented Jan 6, 2026 •

edited

Loading