-
Notifications
You must be signed in to change notification settings - Fork 63
[1796] Remove duplicated code for diagram and ViewUsage creation #1802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
AxelRICHARD
merged 1 commit into
eclipse-syson:main
from
amontagne:alm/enh/remove-duplicates
Jan 8, 2026
Merged
[1796] Remove duplicated code for diagram and ViewUsage creation #1802
AxelRICHARD
merged 1 commit into
eclipse-syson:main
from
amontagne:alm/enh/remove-duplicates
Jan 8, 2026
+112
−104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amontagne
commented
Jan 7, 2026
...services/src/main/java/org/eclipse/syson/diagram/services/DiagramMutationDiagramService.java
Show resolved
Hide resolved
...in/java/org/eclipse/syson/application/sysmlv2/SysMLv2TemplatesRepresentationInitializer.java
Show resolved
Hide resolved
Member
|
Could you please:
|
AxelRICHARD
reviewed
Jan 7, 2026
...in/java/org/eclipse/syson/application/sysmlv2/SysMLv2TemplatesRepresentationInitializer.java
Show resolved
Hide resolved
...in/java/org/eclipse/syson/application/sysmlv2/SysMLv2TemplatesRepresentationInitializer.java
Outdated
Show resolved
Hide resolved
...in/java/org/eclipse/syson/application/sysmlv2/SysMLv2TemplatesRepresentationInitializer.java
Outdated
Show resolved
Hide resolved
...in/java/org/eclipse/syson/application/sysmlv2/SysMLv2TemplatesRepresentationInitializer.java
Outdated
Show resolved
Hide resolved
...del-services/src/main/java/org/eclipse/syson/model/services/ModelMutationElementService.java
Outdated
Show resolved
Hide resolved
...del-services/src/main/java/org/eclipse/syson/model/services/ModelMutationElementService.java
Outdated
Show resolved
Hide resolved
ad0f571 to
39e3157
Compare
Member
|
I will merge the PR when the build will be successful. |
AxelRICHARD
approved these changes
Jan 8, 2026
Member
|
It seems the build has failed. |
39e3157 to
836dbd1
Compare
Bug: eclipse-syson#1796 Signed-off-by: Anne-Lore Montagne <anne-lore.montagne@cea.fr>
836dbd1 to
43a17bb
Compare
Contributor
Author
|
I removed an unused import and resolved the merge conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PLEASE READ ALL ITEMS AND CHECK ONLY RELEVANT CHECKBOXES BELOW
Auto review
Project management
priority:andpr:labels been added to the pull request? (In case of doubt, start with the labelspriority: lowandpr: to review later)area:,type:)Changelog and release notes
CHANGELOG.adoc+doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adocbeen updated to reference the relevant issues?CHANGELOG.adoc?CHANGELOG.adoc?doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?Key highlightssection indoc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?Documentation
Tests