Skip to content

Conversation

@amontagne
Copy link
Contributor

@amontagne amontagne commented Jan 7, 2026

PLEASE READ ALL ITEMS AND CHECK ONLY RELEVANT CHECKBOXES BELOW

Auto review

  • Have you reviewed this PR? Please do a first quick review, It is very useful to detect typos and missing copyrights, check comments, check your code... The reviewer will thank you for that :)

Project management

  • Has the pull request been added to the relevant milestone?
  • Have the priority: and pr: labels been added to the pull request? (In case of doubt, start with the labels priority: low and pr: to review later)
  • Have the relevant issues been added to the pull request?
  • Have the relevant labels been added to the issues? (area:, type:)
  • Have the relevant issues been added to the same project milestone as the pull request?

Changelog and release notes

  • Has the CHANGELOG.adoc + doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc been updated to reference the relevant issues?
  • Have the relevant API breaks been described in the CHANGELOG.adoc?
  • Are the new / upgraded dependencies mentioned in the relevant section of the CHANGELOG.adoc?
  • In case of a change with a visual impact, are there any screenshots in the doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?
  • In case of a key change, has the change been added to Key highlights section in doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?

Documentation

  • Have you included an update of the documentation in your pull request? Please ask yourself if an update (installation manual, user manual, developer manual...) is needed and add one accordingly.

Tests

  • Is the code properly tested? Any pull request (fix, enhancement or new feature) should come with a test (or several). It could be unit tests, integration tests or cypress tests depending on the context. Only doc and releng pull request do not need for tests.

@amontagne amontagne marked this pull request as ready for review January 7, 2026 10:15
@AxelRICHARD
Copy link
Member

Could you please:

  • add an entry in the changelog
  • update the copyrights of the modified files by adding 2026 (see recent modifications to see how it has been done)

@amontagne amontagne force-pushed the alm/enh/remove-duplicates branch 5 times, most recently from ad0f571 to 39e3157 Compare January 8, 2026 07:46
@AxelRICHARD
Copy link
Member

I will merge the PR when the build will be successful.
Thank you for this first contribution!

@AxelRICHARD
Copy link
Member

It seems the build has failed.
@amontagne Could you please fix the errors?

@amontagne amontagne force-pushed the alm/enh/remove-duplicates branch from 39e3157 to 836dbd1 Compare January 8, 2026 12:09
Bug: eclipse-syson#1796
Signed-off-by: Anne-Lore Montagne <anne-lore.montagne@cea.fr>
@amontagne amontagne force-pushed the alm/enh/remove-duplicates branch from 836dbd1 to 43a17bb Compare January 8, 2026 12:17
@amontagne
Copy link
Contributor Author

I removed an unused import and resolved the merge conflicts.

@AxelRICHARD AxelRICHARD merged commit ddf8de0 into eclipse-syson:main Jan 8, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove duplicated code from SysMLv2ProjectTemplatesInitializer and CreateRepresentationInputProcessor

2 participants