Websocket improvement headers #330
Conversation
joelguittet
force-pushed
the
websocket-improvement-headers
branch
2 times, most recently
from
7ef175b to
d660977
Compare
The header Sec-WebSocket-Protocol is optional in both the request and the response from the server. Signed-off-by: Joel Guittet <joelguittet@gmail.com>
The Authorization: Bearer header allow to perform authentication providing a token. It is optional. Signed-off-by: Joel Guittet <joelguittet@gmail.com>
joelguittet
force-pushed
the
websocket-improvement-headers
branch
from
d660977 to
5372101
Compare
|
Thank you for this contribution, @joelguittet. @eclipse-threadx/iot-threadx-committers: Please review this PR. |
|
Any news here @fdesbiens ? Thanks for your support |
|
Hi @joelguittet. A few team members took vacations in the last few weeks, including myself. I will nudge the group about reviewing this. I appreciate your patience. |
|
I understand, thanks for your feedback |
|
@joelguittet I changed the target branch to dev since we accumulate fixes and new features there ahead of the next release. This PR will be merged with master if the review is successful, in our next release (probably in September). Thank you for accepting to review, @yuxinzhou5. |
|
@fdesbiens ok understood. I should rebase on top of dev in this case. If master and dev are not at the same commit, this pr wrongly shows plenty of unrelated commits. |
|
Reviewed and approved. |
|
Thanks! |
3 participants
The purpose of this Pull-Request is to propose two websocket improvments regarding headers: