fix(index): support EJS inside HTML opening tags (fixes #11) #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use control characters (\x01, \x02) as placeholders instead of <!...!> which Prettier v3's stricter HTML parser rejects inside attributes.
BREAKING CHANGE: Requires Prettier 3.x (import path changed from `prettier/parser-html` to `prettier/plugins/html`) Use length-preserving placeholders to completely hide EJS content from prettier, and prevent AST parser getting confused. like from `<input <%= foo ? 'checked' : '' %> />`. Fixes ecmel#11
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use control characters (\x01, \x02) as placeholders instead of <!...!> which Prettier v3's stricter HTML parser rejects inside attributes.
I then found that Prettier was mucking with some EJS constructs -- so to avoid that, we're replacing the EJS with a placeholder value -- but you have to be careful to have your placeholder be exactly the same characters long, or Bad Things happen.