Feature: Per-task performance monitoring #1245
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit consolidates the monitoring infrastructure into a cleaner, more unified API: **Runtime Context Consolidation:** - Removed QueryRuntimeContext in favor of generic TaskRuntimeContext - Moved TaskMetrics and performance monitoring methods to task_runtime_context.rs - TaskRuntimeContext now supports all task types via TaskType enum **Instrumentation Consolidation:** - Removed InstrumentedQueryExecution in favor of generic InstrumentedTaskExecution - Added convenience methods: for_query() and for_query_with_task_id() - InstrumentedTaskExecution handles all task types (queries, dumps, compactions, etc.) **Module Renaming:** - Renamed task_context to task_type for clarity - Avoids confusion with task_runtime_context - Better reflects that the module contains the TaskType enum **Performance Monitoring:** - All metrics methods consolidated in TaskMetrics: - busy_duration_ms(), idle_duration_ms() - avg_poll_duration_us() - cpu_utilization(), cpu_utilization_f64() - Thread tracking and parallelism metrics **API Improvements:** - Single, consistent API for all instrumentation needs - Query-specific shortcuts for common use cases - Better separation of concerns between modules 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
…s gathering Signed-off-by: John Swanson <jswanson@edgeandnode.com>
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per task (i.e. flight/json queries and dump job) instrumentation and metrics reporting.
TODO: