feat: impl job resume #1506
Open
feat: impl job resume #1506
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shiyasmohd
force-pushed
the
shiyasmohd/job-resume
branch
from
71141dd to
1e84490
Compare
LNSD
requested changes
Dec 22, 2025
Contributor
LNSD
left a comment
LNSD
left a comment
There was a problem hiding this comment.
In my opinion, we should not restart a job that is already in a terminal state, such as STOPPED.
Furthermore, I don't see a point in adding a pause/resume mechanism to the jobs, given that the underlying worker logic doesn't support those actions.
In my opinion, we should put the "pause and resume jobs" feature request on hold until we have a better understanding of what operator use cases this would cover.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
scheduler&workerfor jobs inSTOPPEDstate.admin-apiendpointPUT /jobs/{id}/resumeto resume a job.ampctl job resumecommand to resume jobs viaadmin-apiadmin-apiCloses #1058