feat: support custom asset url #36
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #36 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 194 194
=========================================
Hits 194 194 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Author
|
建议允许开发者设置这个url，不然局域网内其他设备没有办法访问 |
|
+1, 建议允许用户自定义 url |
popomore
reviewed
Jun 9, 2020
| } | ||
| const protocol = app.options.https ? 'https' : 'http'; | ||
| assetsConfig.url = `${protocol}://127.0.0.1:${port}`; | ||
| assetsConfig.url = assetsConfig.url ? assetsConfig.url : `${protocol}://127.0.0.1:${port}`; |
Member
There was a problem hiding this comment.
把 config.local.js 的 url 设为 127.0.0.1？
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm testpassesAffected core subsystem(s)
Description of change