feat: httpclient_next proxy

[Dipper30]

lazy initialize httpclient_next, since plugins may have accessed app.httpclient ealier than config.httpclient.lookup modification

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[gemini-code-assist]

Summary of Changes

Hello @Dipper30, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request implements lazy initialization for the HttpClientNext instance within the createHttpClient method. The primary goal is to resolve an issue where plugins might access the HTTP client before its lookup configuration is finalized. By deferring the client's instantiation through a Proxy, the system guarantees that all httpclient.lookup settings are correctly applied at the point of first use, enhancing configuration reliability and preventing potential race conditions with configuration updates.

Highlights

• Lazy Initialization of HttpClientNext: The HttpClientNext instance is now lazily initialized using a JavaScript Proxy within the createHttpClient method.
• Configuration Consistency: This change ensures that config.httpclient.lookup modifications are correctly applied, even if app.httpclient is accessed by plugins before the configuration is fully set up.
• Proxy Implementation: A Proxy is used to defer the creation of the HttpClientNext instance until its first access, handling both property get and set operations to ensure proper method binding and property assignment.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces lazy initialization for HttpClientNext using a Proxy. The goal is to ensure that HttpClientNext is created with the most up-to-date configuration, particularly config.httpclient.lookup, which might be modified by plugins after the httpclient is first accessed.

The approach is sound, but the Proxy implementation could be improved. I've left a comment with suggestions to refactor duplicated code and to make the proxy more robust by implementing missing traps, which could otherwise lead to unexpected behavior with reflective operations. Addressing this will make the implementation more complete and maintainable.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.54%. Comparing base (13d9a19) to head (feaab27).
⚠️ Report is 2 commits behind head on 3.x.

Additional details and impacted files

@@           Coverage Diff           @@
##              3.x    #5763   +/-   ##
=======================================
  Coverage   99.53%   99.54%           
=======================================
  Files          36       36           
  Lines        3678     3722   +44     
  Branches      549      562   +13     
=======================================
+ Hits         3661     3705   +44     
  Misses         17       17           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[killagu]

LGTM

[github-actions]

🎉 This PR is included in version 3.33.0 🎉

The release is available on:

• npm package (@release-3.x dist-tag)
• GitHub release

Your semantic-release bot 📦🚀