Skip to content

Conversation

@wdconinc
Copy link
Contributor

Briefly, what does this PR introduce?

This PR is a quality-of-life improvement in advance of #35. It is always a bit annoying to figure out which of the cherry-picks need to be retained. This PR will print the ones that can be dropped, but more importantly it won't fail on them when cherry-pick wants to apply them again (since they will be skipped).

Copilot AI review requested due to automatic review settings December 25, 2025 01:08
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds resilience to the cherry-pick process by detecting and skipping commits that have already been applied to the current branch. This prevents failures when cherry-picks are re-listed and improves the user experience by clearly indicating which cherry-picks can be safely dropped.

Key Changes:

  • Adds ancestor checking before applying cherry-picks to prevent duplicate application
  • Provides informative console output for skipped commits

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings December 25, 2025 01:16
@wdconinc wdconinc enabled auto-merge (squash) December 25, 2025 01:16
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings December 25, 2025 16:36
@wdconinc wdconinc requested a review from veprbl December 25, 2025 16:46
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 4 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@wdconinc
Copy link
Contributor Author

This works as intended when cherry-picked into #35, see e.g. https://github.com/eic/containers/actions/runs/20508969170/job/58927593032#step:14:685

@wdconinc wdconinc merged commit 1a9be61 into master Dec 26, 2025
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants