chore: py-flatbuffers-25.9.23 #102
Merged
+6
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR upgrades the py-flatbuffers package to support spack-1.1.0, but there is a critical version number discrepancy between the PR title/description (25.9.3) and the actual code changes (25.9.23).
Key Changes:
- Adds a new commit hash to the cherry-pick list in spack-packages.sh
- Sets a minimum version requirement for py-flatbuffers in packages.yaml
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| spack-packages.sh | Adds commit hash for py-flatbuffers update and documents it with version v25.9.23 (conflicts with PR title) |
| spack-environment/packages.yaml | Adds version requirement constraint for py-flatbuffers at version 25.9.23 or higher (conflicts with PR title) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This was referenced Dec 25, 2025
veprbl
approved these changes
Dec 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce?
This PR upgrades flatbuffers to 25.9.23 for spack-1.1.0 support (see spack/spack-packages#2485).