Skip to content

Conversation

@wdconinc
Copy link
Contributor

Briefly, what does this PR introduce?

This PR moves the explicit hinting for root and dd4hep dependents into a separate package file, to ensure this is handled consistently by being defined in a single place.

Copilot AI review requested due to automatic review settings December 25, 2025 16:32
@wdconinc wdconinc enabled auto-merge (squash) December 25, 2025 16:48
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces centralized configuration for root package variants by creating separate package configuration files (packages_root_with_opengl.yaml and packages_root_without_opengl.yaml) and updates two spack environments (xl and ci) to use these configuration files instead of explicit variant flags.

  • Creates two new package configuration files for root variants (with and without OpenGL)
  • Updates xl and ci environments to use centralized root configuration
  • Removes explicit dd4hep variant flags from xl and ci environments

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File Description
spack-environment/xl/spack.yaml Includes packages_root_with_opengl.yaml and removes explicit root and dd4hep variant flags
spack-environment/ci/spack.yaml Includes packages_root_without_opengl.yaml and removes explicit root and dd4hep variant flags
spack-environment/packages_root_with_opengl.yaml New file defining root package requirements with OpenGL and WebGUI enabled
spack-environment/packages_root_without_opengl.yaml New file defining root package requirements with OpenGL and WebGUI disabled

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@wdconinc wdconinc requested a review from veprbl December 26, 2025 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants