-
Notifications
You must be signed in to change notification settings - Fork 5
fix: define root/dd4hep hints as packages config #104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR introduces centralized configuration for root package variants by creating separate package configuration files (packages_root_with_opengl.yaml and packages_root_without_opengl.yaml) and updates two spack environments (xl and ci) to use these configuration files instead of explicit variant flags.
- Creates two new package configuration files for root variants (with and without OpenGL)
- Updates xl and ci environments to use centralized root configuration
- Removes explicit dd4hep variant flags from xl and ci environments
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| spack-environment/xl/spack.yaml | Includes packages_root_with_opengl.yaml and removes explicit root and dd4hep variant flags |
| spack-environment/ci/spack.yaml | Includes packages_root_without_opengl.yaml and removes explicit root and dd4hep variant flags |
| spack-environment/packages_root_with_opengl.yaml | New file defining root package requirements with OpenGL and WebGUI enabled |
| spack-environment/packages_root_without_opengl.yaml | New file defining root package requirements with OpenGL and WebGUI disabled |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Briefly, what does this PR introduce?
This PR moves the explicit hinting for root and dd4hep dependents into a separate package file, to ensure this is handled consistently by being defined in a single place.