Skip to content

Conversation

@nabijaczleweli
Copy link

Closes #764

Ref: #775:

$ git diff -U0 upstream/master Cargo.lock | grep -FA1 '[[package]]' | paste - - -
-[[package]]    -name = "base58-monero" --
-[[package]]    -name = "fixed-hash"    --
-[[package]]    -name = "hex-literal"   --
-[[package]]    -name = "keccak-hash"   --
-[[package]]    -name = "monero"        --
+[[package]]    +name = "monero-amount" --
-[[package]]    -name = "primitive-types"       --
-[[package]]    -name = "rustc-hex"     --
-[[package]]    -name = "serde-big-array"       --
-[[package]]    -name = "tiny-keccak"

@binarybaron
Copy link

Thanks a lot for taking this on!

I'll review this soon. Over the holidays I'll have less time but I'll try to make this a priority.

The general approach looks sound. One nitpick I have is that I'd like to have all the monero-oxide extension types (alternatives to monero-rs) moved into a single crate. Name would probably be monero-oxide-ext.

We should also take a look at how Cuprate handles this.

I'll leave more detailed actionable comments soon.

@nabijaczleweli
Copy link
Author

nabijaczleweli commented Dec 22, 2025

This does do this, I just called it monero-amount here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[0.6 XMR] Switch entirely to monero-oxide

2 participants