Add environment variable for location of wordlist #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows you to call genhost from anywhere (it may be in your ~/bin). This fixes a bug with it wouldn't use the wordlist variable, and always use the file `wordlist`.
elasticdog
reviewed
Jan 22, 2020
Owner
elasticdog
left a comment
elasticdog
left a comment
There was a problem hiding this comment.
Thank you for the contribution! I have one small suggested tweak to help prevent issues if there are spaces in the directory name, but otherwise I'd be glad to get this merged.
| esac | ||
| elif [[ $1 == "list" ]]; then | ||
| grep "#" wordlist | sed 's/#//' | ||
| grep "#" ${wordlist} | sed 's/#//' |
Owner
There was a problem hiding this comment.
Could you quote this variable to prevent word splitting?
hughdavenport
added a commit
to hughdavenport/dotfiles
that referenced
this pull request
May 20, 2020
Need to wait for upstream elasticdog/genhost#7 and then can use submodules
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows you to call genhost from anywhere (it may be in your ~/bin).
This fixes a bug with it wouldn't use the wordlist variable, and always use the file
wordlist.