Update sidebar icons #299
Merged
Update sidebar icons #299
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Take care of elementary#287 by update to use view-sidebar-end-symbolic instead of pane-show-symbolic and pane-hide-symbolic.
danirabbit
reviewed
Jan 7, 2026
Member
danirabbit
left a comment
danirabbit
left a comment
There was a problem hiding this comment.
Awesome thank you! Just one small request
Just set the icon_name when create button instance.
Member
|
This looks good, but it looks like this icon name isn't available in the flatpak platform that calculator is currently targeting. So we either need to gresource it or wait until a new platform. Sorry for the complication! |
Add icon view-sidebar-end-symbolic.svg as a custom resource.
Contributor
Author
|
Thx! No worries! It was a learning opportunity for me to add a custom resource, so I was happy about it. Hope I did place the build instructions in the correct meson files. :) |
danirabbit
requested changes
Jan 15, 2026
Member
danirabbit
left a comment
danirabbit
left a comment
There was a problem hiding this comment.
Nice job! Almost perfect. Just one small suggestion to fix the icon color in dark mode
As title.
danirabbit
approved these changes
Jan 19, 2026
Member
danirabbit
left a comment
danirabbit
left a comment
There was a problem hiding this comment.
Great work. Thanks for jumping through a couple hoops!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #287
Take care of #287 by update to use view-sidebar-end-symbolic instead of pane-show-symbolic and pane-hide-symbolic.