Skip to content

Conversation

@marbetschar
Copy link
Member

Uses Granite.HyperTextView for the comment textview of an event. This allows to Ctrl + Click on an existing hyperlink in the event description.

Makes #692 obsolete.

@marbetschar marbetschar added the Good First Issue Small, self-contained issue. Good for newcomers, and/or should be an easy fix. label Dec 1, 2021
@marbetschar marbetschar requested a review from a team December 1, 2021 09:53
@marbetschar marbetschar changed the title Granite.HyperTextView Granite.HyperTextView: Support for clickable hyperlinks in event description Dec 1, 2021
Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you bump the granite requirement in the README and add a line to appdata as well please? :)

@marbetschar
Copy link
Member Author

Sure thing, thanks for the reminder! :)

@danirabbit danirabbit merged commit f030f72 into master Dec 2, 2021
@danirabbit danirabbit deleted the granite-hypertextview branch December 2, 2021 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Good First Issue Small, self-contained issue. Good for newcomers, and/or should be an easy fix.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants