Skip to content

EventMenu: Gtk4 Prep #879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
danirabbit wants to merge 2 commits into
base: master
Choose a base branch
from
Open

EventMenu: Gtk4 Prep #879

danirabbit wants to merge 2 commits into from
+36 −63

Conversation

@danirabbit
Copy link
Member

@danirabbit danirabbit commented Jan 16, 2026 •
edited
Loading

Can be rebase merged

  • Use GLib.Menu instead of Gtk.MenuItem
  • PopoverMenu is sealed in GTK4, so make this a namespace with a static func to return a menu.
  • While we're here, set item sensitivity when the menu is shown, not when it's constructed. This way we can cache a copy of the menu and don't have to construct a new one every time

@danirabbit danirabbit requested a review from a team January 16, 2026 16:46
@danirabbit danirabbit moved this to Needs Review in GTK4 Porting Jan 16, 2026
leolost2605
leolost2605 reviewed Jan 16, 2026
View reviewed changes
@danirabbit danirabbit force-pushed the danirabbit/eventmenu-gtk4 branch from a1c2f4c to 0d6d471 Compare January 16, 2026 17:29
@danirabbit danirabbit force-pushed the danirabbit/eventmenu-gtk4 branch 4 times, most recently from e95ba0f to f33917c Compare January 20, 2026 15:52
@danirabbit
Copy link
Member Author

danirabbit commented Jan 20, 2026

@leolost2605 can I get a re-review please : )

@danirabbit danirabbit force-pushed the danirabbit/eventmenu-gtk4 branch 3 times, most recently from 51a491c to 32d7218 Compare January 26, 2026 19:19
@danirabbit
EventMenu: Use GLib.Menu
e3a87c7 
Fix remove item labels

Fix extra whitespace
@danirabbit
EventMenu: don't subclass menu
94dd592 
Make it a namespace
@danirabbit danirabbit force-pushed the danirabbit/eventmenu-gtk4 branch from 32d7218 to 94dd592 Compare January 26, 2026 20:45
leolost2605
leolost2605 approved these changes Jan 27, 2026
View reviewed changes
Copy link
Member

@leolost2605 leolost2605 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't tested but LGTM with the little comment :)

src/Widgets/EventMenu.vala

E.Source src = comp.get_data ("source");
menu.popped_up.connect (() => {
var sensitive = src.writable == true && Calendar.EventStore.get_default ().calclient_is_readonly (src) == false;
Copy link
Member

@leolost2605 leolost2605 Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
var sensitive = src.writable == true && Calendar.EventStore.get_default ().calclient_is_readonly (src) == false;
var sensitive = src.writable && !Calendar.EventStore.get_default ().calclient_is_readonly (src);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leolost2605 leolost2605 leolost2605 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

GTK4 Porting
Status: Needs Review

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@danirabbit @leolost2605