FileChooserPortal: Use existing view widgets after moving to libcore #2711
+3,478
−1,491
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #2679, builds on #2710,
Fixes #129 and (potentially) many others
This PR replaces the existing Gtk.FileChooser with a widget that implements most of the Files app functionality and uses mostly the same widgets.
To avoid problems previously encounted with Gtk.FileFilterInfo, we implement our own simplified filtering with
Files.FileFilter. Only mime-type and glob filtering are implemented.Much of this can be split out into small PRs so it is not expected that this PR will be merged in toto.
Currently partially works but needs further work. The Miller view awaits transfer to
libcoreso does not work in the portal. Othewise most of thesrcfolder has been transferred tolibcore.The
testssubfolder will be lost before mergingNote: Only works if app use the portal (e.g. Flatpaks) . Native Gtk3 apps must be run with the environment variable
GTK_USE_PORTAL=1and use Gtk.FileChooserNative otherwise the native Gtk.FileChooser will appear.