Do not force journal mode unless specified #341
Merged
+13
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let SQLite use the default journal mode if none is given. This is important because the database may be in WAL mode already (which is persistent) and forcing it to DELETE mode unexpectedly changes the database out of WAL mode (also in a persistent way).
warmwaffles
approved these changes
Dec 22, 2025
Member
|
I didn't realize this was a problem because I've always left it in WAL mode in my personal projects. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let SQLite use the default journal mode if none is given. This is important because the database may be in WAL mode already (which is persistent) and forcing it to DELETE mode unexpectedly changes the database out of WAL mode (also in a persistent way).
Closes #340.