Fix GTest SetUpTestSuite bug #339
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since RC_GTEST_FIXTURE_PROP is not registering the properties as GTest test cases within the given fixture, if the given fixture defines SetUpTestSuite or TearDownTestSuite they will not be called by RapidCheck, and there is no guarantee that they have already been called by GTest. This will result in bugs. Fix this issue by ensuring that the properties are registered as test cases in the given GTest fixture. This slightly alters the naming scheme for GTest test cases generated by RC_GTEST_FIXTURE_PROP.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since RC_GTEST_FIXTURE_PROP is not registering the properties as GTest test cases within the given fixture, if the given fixture defines SetUpTestSuite or TearDownTestSuite they will not be called by RapidCheck, and there is no guarantee that they have already been called by GTest. This will result in bugs.
Fix this issue by ensuring that the properties are registered as test cases in the given GTest fixture.
This slightly alters the naming scheme for GTest test cases generated by RC_GTEST_FIXTURE_PROP.
Resolves #338