Don't error if the oppportunistic statat fails in fd_count #247
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
Author
|
@bobrik does this look OK to you? |
Contributor
|
I think we can also just not pass any flags (pass |
Owner
Author
|
Ah, good point. I somehow had it in my head that the |
This is not supported on 2.6 kernels, and we really don't expect this directory to be a symlink
eminence
force-pushed
the
statat_nofollow
branch
from
529c594 to
d0a7c09
Compare
bobrik
approved these changes
Feb 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was reported (#241) that old kernels (2.6) will return a failure if SYMLINK_NOFOLLOW is used, so lets check for errors here.