Replace BASS with minimp3+kissfft for audio decoding #177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the proprietary BASS library and replaces it with: - minimp3: Header-only MP3 decoder (public domain) - kissfft: Small FFT library (BSD license) Benefits: - No more proprietary dependencies - Enables universal macOS builds (BASS lacked arm64 support) - Simpler distribution (no DLLs/dylibs to bundle) Changes: - Remove external/bass/ directory and all binaries - Add external/minimp3/ and external/kissfft/ - Simplify CMakeLists.txt (remove USE_MINIMP3 option) - Update MusicDecode.c to use only minimp3+kissfft - Remove BASS_Init from Editor.c - Update release workflow (no bass.dll copy) - Update README (remove libbass installation steps) Closes #157
emoon
force-pushed
the
minimp3-replacement
branch
from
5faf0d9 to
ebe0430
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
external/bass/directory and all platform binariesexternal/minimp3/andexternal/kissfft/CMakeLists.txt- removeUSE_MINIMP3option, minimp3 is now the only backendMusicDecode.cto use only minimp3+kissfft implementationBASS_InitfromEditor.cCloses #157