Build macOS universal binary (x86_64 + arm64) #178
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that BASS is removed, we can build universal binaries that run natively on both Intel and Apple Silicon Macs. Changes: - Update CMAKE_OSX_ARCHITECTURES to include both x86_64 and arm64 - Update release workflow to explicitly build universal binary - Add verification step to confirm both architectures are present - Rename release artifact to RocketEditor-macOS-universal.zip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Now that BASS is removed, we can build universal binaries that run natively on both Intel and Apple Silicon Macs.
Changes
CMAKE_OSX_ARCHITECTURESto"x86_64;arm64"fileandlipo -infoto confirm both architecturesRocketEditor-macOS-universal.zip