Python/Django implementation #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
August 1, 2015 17:39
- `find_packages()` does not respect `package_dir` and needs to be explicitly told to search a sub directory package. - `install` and `develop` were generating the fixture in the /tmp directory, but the files were not copied to the target directory. - The `test` command on python 2 uses an 'in place' install of the package, so the build_py phase is never executed. It's necessary for the test command to manually build the fixture before execution.
3 tasks
|
This is awesome ryan! Thank you so much. I'm going to try to review this tomorrow. |
Author
|
Hi - any objection to me going ahead and uploading this to pypi? |
|
None whatsoever! |
|
Also, fuck. I'm really sorry I haven't landed this already. Completely fell off the radar. |
|
Bump. This could be useful if merged. |
Author
|
Hi @TMiguelT |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I've spent a little time working on a Django version of the models and fixtures. This also includes a simple test to ensure that the models and fixtures are compatible with Django and its test utilities. To run the test suite:
$ git checkout python $ python setup.py testIf everything looks good, what are your thoughts on releasing the package to PyPI? I'd be happy to help with/own the python releases, as well as updating the python code. It might also be worth noting that PyPI allows for multiple package owners and maintainers.