Enhance memory management features and IStorage/IStream tests.
#901
+157
−32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensures that the `pwcsName` field of the `tagSTATSTG` structure, returned by `IStorage.Stat`, correctly reflects the file path used during the creation of a compound file. This enhances the `test_Stat` in `test_storage.py` by verifying the consistency of the storage's reported name with its physical location.
…d `IStream` tests.
Added validation for `ctime`, `atime`, and `mtime` `FILETIME` timestamps within the `tagSTATSTG` structure in `test_storage.py`.
Introduced `test_SetElementTimes` in `test_storage.py` to verify the functionality of the `IStorage.SetElementTimes` method.
Directly import `c_size_t` as `SIZE_T` from `ctypes` to remove an unnecessary alias assignment, streamlining type definition.
…unction. Introduced a `CoGetMalloc` utility function in `comtypes/malloc.py` to encapsulate the low-level `_CoGetMalloc` API call. This new function streamlines the acquisition of the OLE task memory allocator by standardizing the `dwMemContext` parameter to `1`, which is the only supported value for `CoGetMalloc`.
Removed assertions for `IMalloc.DidAlloc` after `del stat` in `test_storage.py` and `test_stream.py`.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #901 +/- ##
==========================================
+ Coverage 85.61% 85.68% +0.07%
==========================================
Files 128 128
Lines 12074 12137 +63
==========================================
+ Hits 10337 10400 +63
Misses 1737 1737 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces several enhancements to memory management utilities and extends the test coverage for
IStorageandIStreaminterfaces.Add new
CoGetMallocfunction tomalloc.py:IMallocpointer retrieval into a high-level wrapperCoGetMallocutility function. This ensures consistent and type-hinted access to the memory allocator across the codebase.New Test for
IStorage.SetElementTimes:IStorage.SetElementTimesmethod. This new test verifies that modification times are correctly set for storage elements.Memory Management Test Enhancements for
IStorage.StatandIStream.Stat:pwcsNamememory allocation withinIStorage.StatandIStream.Stattests.Enhance Validation in
IStorage.Stat:IStorage.Stattests.