-
Notifications
You must be signed in to change notification settings - Fork 647
feat: add support for tracing tags #7828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
wait #7540 |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7828 +/- ##
==========================================
- Coverage 72.87% 72.82% -0.05%
==========================================
Files 237 237
Lines 35509 35517 +8
==========================================
- Hits 25877 25867 -10
- Misses 7792 7808 +16
- Partials 1840 1842 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
✅ Deploy Preview for cerulean-figolla-1f9435 canceled.
|
Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: zirain <zirain2009@gmail.com>
arkodg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks
| } | ||
|
|
||
| for k, v := range tags { | ||
| out = append(out, &tracingtype.CustomTag{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question: Could tags and customTags conflict with each other? Should we de-duplicate them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it could, and we mentioned in the API that tags take precedence.
xref: #7795