Skip to content

Conversation

@zirain
Copy link
Member

@zirain zirain commented Dec 27, 2025

xref: #7795

@zirain
Copy link
Member Author

zirain commented Dec 27, 2025

wait #7540

@codecov
Copy link

codecov bot commented Dec 27, 2025

Codecov Report

❌ Patch coverage is 61.11111% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.82%. Comparing base (b28b77c) to head (d42942f).

Files with missing lines Patch % Lines
internal/xds/translator/tracing.go 56.25% 6 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7828      +/-   ##
==========================================
- Coverage   72.87%   72.82%   -0.05%     
==========================================
  Files         237      237              
  Lines       35509    35517       +8     
==========================================
- Hits        25877    25867      -10     
- Misses       7792     7808      +16     
- Partials     1840     1842       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@netlify
Copy link

netlify bot commented Jan 14, 2026

Deploy Preview for cerulean-figolla-1f9435 canceled.

Name Link
🔨 Latest commit d42942f
🔍 Latest deploy log https://app.netlify.com/projects/cerulean-figolla-1f9435/deploys/696de27b9d7ac000081fd1fa

@zirain zirain marked this pull request as ready for review January 14, 2026 06:23
@zirain zirain requested a review from a team as a code owner January 14, 2026 06:23
@zirain zirain added this to the v1.7.0-rc.1 Release milestone Jan 16, 2026
Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: zirain <zirain2009@gmail.com>
arkodg
arkodg previously approved these changes Jan 17, 2026
Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks

@arkodg arkodg requested review from a team January 17, 2026 20:17
}

for k, v := range tags {
out = append(out, &tracingtype.CustomTag{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: Could tags and customTags conflict with each other? Should we de-duplicate them?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it could, and we mentioned in the API that tags take precedence.

Signed-off-by: zirain <zirain2009@gmail.com>
@zirain zirain requested a review from zhaohuabing January 19, 2026 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants