-
Notifications
You must be signed in to change notification settings - Fork 647
feat: cookie based match #7932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: cookie based match #7932
Conversation
✅ Deploy Preview for cerulean-figolla-1f9435 canceled.
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #7932 +/- ##
==========================================
- Coverage 72.86% 72.85% -0.01%
==========================================
Files 237 237
Lines 35536 35610 +74
==========================================
+ Hits 25894 25945 +51
- Misses 7799 7818 +19
- Partials 1843 1847 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
0881dbc to
94107db
Compare
Signed-off-by: Huabing(Robin) Zhao <zhaohuabing@gmail.com>
Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
9bcf784 to
5ace9f4
Compare
Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
5ace9f4 to
51f87dc
Compare
Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
c1f26a4 to
b460ac8
Compare
Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
arkodg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks !
This PR extends HTTPRouteFilter with cookie match predicates and ANDs them with HTTPRoute rule matches to generate the match matrix.
Cookie matches uses the cookie matchers introduced in envoyproxy/envoy#42662, without parsing cookie header with the Header matchers.
Implement: #6199