Skip to content

Conversation

@zhaohuabing
Copy link
Member

@zhaohuabing zhaohuabing commented Jan 13, 2026

This PR extends HTTPRouteFilter with cookie match predicates and ANDs them with HTTPRoute rule matches to generate the match matrix.
Cookie matches uses the cookie matchers introduced in envoyproxy/envoy#42662, without parsing cookie header with the Header matchers.

Implement: #6199

@zhaohuabing zhaohuabing requested a review from a team as a code owner January 13, 2026 04:17
@netlify
Copy link

netlify bot commented Jan 13, 2026

Deploy Preview for cerulean-figolla-1f9435 canceled.

Name Link
🔨 Latest commit 7c9b9a3
🔍 Latest deploy log https://app.netlify.com/projects/cerulean-figolla-1f9435/deploys/696e0091b254bb000870fe32

@zhaohuabing zhaohuabing added this to the v1.7.0-rc.1 Release milestone Jan 13, 2026
@zhaohuabing zhaohuabing changed the title feature: cookie based match api: cookie based match Jan 13, 2026
@codecov
Copy link

codecov bot commented Jan 13, 2026

Codecov Report

❌ Patch coverage is 82.02247% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.85%. Comparing base (844be64) to head (7c9b9a3).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
internal/gatewayapi/route.go 87.93% 6 Missing and 1 partial ⚠️
internal/gatewayapi/sort.go 50.00% 3 Missing and 3 partials ⚠️
internal/ir/xds.go 0.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7932      +/-   ##
==========================================
- Coverage   72.86%   72.85%   -0.01%     
==========================================
  Files         237      237              
  Lines       35536    35610      +74     
==========================================
+ Hits        25894    25945      +51     
- Misses       7799     7818      +19     
- Partials     1843     1847       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@zhaohuabing zhaohuabing changed the title api: cookie based match feat: cookie based match Jan 16, 2026
@zhaohuabing zhaohuabing marked this pull request as draft January 16, 2026 07:02
Signed-off-by: Huabing(Robin) Zhao <zhaohuabing@gmail.com>
Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
@zhaohuabing zhaohuabing force-pushed the impl-6199 branch 2 times, most recently from 9bcf784 to 5ace9f4 Compare January 16, 2026 07:07
Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
@zhaohuabing zhaohuabing marked this pull request as ready for review January 19, 2026 10:00
@zhaohuabing zhaohuabing requested a review from jukie January 19, 2026 23:50
Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks !

@zirain zirain merged commit d39a5a0 into envoyproxy:main Jan 20, 2026
62 of 65 checks passed
@zhaohuabing zhaohuabing deleted the impl-6199 branch January 20, 2026 03:00
@zirain zirain mentioned this pull request Jan 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants